Edgewall Software

Ticket #1562 (closed defect: fixed)

Opened 3 years ago

Last modified 23 months ago

Link problem for reports with dynamic variables

Reported by: t.dettrick@… Owned by: daniel
Priority: normal Milestone: 0.9
Component: report system Version: 0.9b2
Severity: major Keywords:
Cc: trac-form@…

Description

Links given as:

[report:123?MYVAR=myvalue My Report]

result in all of the links on the generated report consisting of things like:

http://...../report/123?MYVAR=myvalue/ticket/345

As of Revision 1677.

Attachments

report-fix.diff (0.8 kB) - added by trac-form@… 3 years ago.
Dubious fix for this bug.

Change History

Changed 3 years ago by t.dettrick@…

It appears to do this because the link:

[report:123?MYVAR=myvalue My Report]

generates the href:

...../report/11%3FMYVAR%3Dmyvalue

instead of:

...../report/11?MYVAR=myvalue

This confuses Apache into believing that the OS environment variable SCRIPT_NAME is the same as REQUEST_URI, rather than being the URL of the Trac project. Obviously the solution is to stop the GET request parameters being encoded.

Changed 3 years ago by anonymous

  • version changed from devel to 0.9b2
  • milestone set to 0.9

Changed 3 years ago by anonymous

This worked in 0.8.x

Changed 3 years ago by trac-form@…

Dubious fix for this bug.

Changed 3 years ago by trac-form@…

I'm not sure whether this patch is correctly implemented, but it works: eg. http://trac-hacks.swapoff.org/wiki/TocMacro

Changed 3 years ago by anonymous

  • cc trac-form@… added

Changed 3 years ago by cmlenz

  • status changed from new to closed
  • resolution set to fixed

Applied patch in [2322]. Well, except for the part that removed the report shorthand syntax ;-)

Add/Change #1562 (Link problem for reports with dynamic variables)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.